feat(express): add CI check to prevent dockerfile drift #7110
+35
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louib
force-pushed
the
VL-3498-kill-dockerfile-drift
branch
2 times, most recently
from
132f564 to
722e716
Compare
mukeshsp
approved these changes
Sep 29, 2025
zahin-mohammad
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR both kills the drift in the express Dockerfile and adds a CI check to ensure that drift is addressed before merging. Making sure that the Dockerfile is up-to-date at all times will ensure that any BitGoJS commit can be used to publish a new version of
bitgo/express.It feels a little overkill to install all the project's dependencies just for
tsxandexecabut apparently this is a yarn v1 limitation. I'd be happy to be proven wrong here. The new check also didn't really fit in any of the other jobs which is why I created a new job for it.I was able to test this new CI check here
TICKET: VL-3498