feat(sdk-core): add VaultConfig types and defiParams to BuildParams/SendManyOptions#9205
Closed
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Closed
Conversation
…endManyOptions Part 1 of 2 for DEFI-279 (CB-1.8). Types + interfaces + dependency bump: - Add GetVaultConfigOptions, VaultProvider, VaultConfig, ConcreteVaultConfig, ConcreteDepositResult to iDefiVault.ts; update DepositResult to a discriminated union (concrete_btccx pendingApproval | morpho operationId); add getVaultConfig to IDefiVault interface - Add defiParams: t.unknown to BuildParams whitelist so it passes through prebuildWhitelistedParams() without being stripped - Add optional defiParams field to SendManyOptions for discoverability - Bump @bitgo/public-types to ^6.39.0 (picks up defiParams on TxSendBody) Ticket: DEFI-279 Session-Id: ba171a5f-3d3c-4505-9e87-8df8afe5d59f Task-Id: bffe5f00-9f9c-4882-be0f-d620f6eba4c5
Contributor
0d6aded to
3486e3e
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Test plan
Stack
This PR is part 1 of 2 in a stack. Review and merge in order:
Ticket: DEFI-279