fix: upgrade github-comment-specific for semantic-release 25#1160
Merged
Conversation
github-comment-specific 1.0.7 requires p-filter without declaring it, relying on the CJS p-filter@2 that @semantic-release/github@8 hoisted to the top level. semantic-release 25 hoists ESM-only p-filter@4 instead, so the plugin's require() returns a namespace object and the success step throws 'TypeError: _b.apply is not a function' after publishing. Version 2.0.7 is built against @semantic-release/github@12 and no longer depends on p-filter. Ticket: AI-744 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ericcrosson-bitgo
enabled auto-merge
July 21, 2026 20:29
shenbenson
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release run 29865224942 published all six packages successfully (trusted publishing + provenance now work end-to-end), but the workflow failed afterward in the
successhook of@semantic-release-extras/github-comment-specific:Version 1.0.7 calls
require("p-filter")without declaring it — a phantom dependency satisfied by the CJSp-filter@2that@semantic-release/github@8used to hoist. The semantic-release 25 upgrade hoists ESM-onlyp-filter@4instead, sorequire()returns a module namespace object and the call throws. Side effect: release-notification comments for that run were skipped (published packages were unaffected).Fix
Upgrade the plugin to 2.0.7, which targets
@semantic-release/github@12/@octokit/rest@22(the semantic-release 25 stack) and no longer uses p-filter. Verified locally that the plugin imports cleanly and exposes all five hooks.Note: multi-semantic-release filters commits per package directory, so this root-only
fix:commit may not cut new package versions by itself — but the release workflow should now complete green, and the next package-touching release will exercise the comment hooks.Ticket: AI-744
🤖 Generated with Claude Code