refactor(express-wrapper): avoid using codec type-guard #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| expressRes.status(status).json(responseCodec.encode(payload)).end(); | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Proving that responseCodec isn't undefined is pretty gross in this implementation 😓 I used a ! because undefined has no encode method will still jump to the catch block
This refactor changes the response code path to try encoding the service function's response value with the apiSpec's response codec, and if this errors returns a 500. Previously we used the codec's type-guard as a test if the codec can encode the service function's response value, but this step will take extra time and there's no hard contract that guarantees us the type-guard returning `true` really means that the codec will be able to encode a value. Instead, we just try the dangerous deed and do our best to catch errors.
ericcrosson-bitgo
force-pushed
the
use-throw
branch
from
6fb1921 to
360202a
Compare
|
🎉 This PR is included in version 1.0.0-beta.10 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.6 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.2 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.6 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor changes the response code path to try encoding the
service function's response value with the apiSpec's response codec,
and if this errors returns a 500.
Previously we used the codec's type-guard as a test if the codec
can encode the service function's response value, but this step will
take extra time and there's no hard contract that guarantees us the
type-guard returning
truereally means that the codec will be ableto encode a value. Instead, we just try the dangerous deed and do our
best to catch errors.