Skip to content

refactor(express-wrapper): avoid using codec type-guard #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2022
Merged

refactor(express-wrapper): avoid using codec type-guard #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/express-wrapper/src/response.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,12 @@ export const defaultResponseEncoder: ResponseEncoder = (
return;
}
const responseCodec = route.response[status];
if (responseCodec === undefined || !responseCodec.is(payload)) {
try {
expressRes.status(status).json(responseCodec!.encode(payload)).end();
} catch {
console.warn(
"Unable to encode route's return value, did you return the expected type?",
);
expressRes.status(500).end();
return;
}

expressRes.status(status).json(responseCodec.encode(payload)).end();
};
Copy link
Contributor Author

@ericcrosson-bitgo ericcrosson-bitgo May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proving that responseCodec isn't undefined is pretty gross in this implementation 😓 I used a ! because undefined has no encode method will still jump to the catch block