Add BTF churn diagnostics - #112
Closed
mtg0001 wants to merge 1 commit into
Closed
Conversation
Owner
|
This is already in The counters did exactly what they were for. They ruled out the two hypotheses I could not separate by reading — descriptors resolved 53 times out of 54, and nothing paired and then went silent — which left dialling, failing half the time, and that is what led to the single-slot registration in the relay. The bench that followed put the fix at 65% → 98% paired under contention. Closing as merged-via-#113. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The churn hypothesis is strong but not proven: some descriptors may point at registrations that are no longer alive, and some paired tunnels may never reach the Bitflash version/message handshake. Fixing that blindly risks training the node around the wrong failure. This PR adds the measurement needed to separate stale descriptors from relay and post-pairing failures.
Testing
git diff --checkmake -f makefile.mingw testsfrom MSYS2 UCRT64 insrc/