Add HD wallet schema metadata - #122
Closed
mtg0001 wants to merge 2 commits into
Closed
Conversation
This was referenced Aug 3, 2026
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hdschema,hdreceivenext, andhdchangenext.legacy-hd(m/index') instead of rewriting them silently.Why
This is the second BIP44 preparation step after #121. The wallet cannot safely move from the existing
m/index'derivation to BIP44 until wallet.dat can say which derivation layout a seed uses. Without that marker, a future restore could scan the wrong path family and make old coins look missing.This PR deliberately does not change address generation yet. It only records and reports the derivation schema boundary so the next PR can add dual-path restore without ambiguity.
Stack
Stacked after #121 (
Add BIP32 path derivation foundation). Review this after #121, or compare this branch againstbip44-foundationto see only the metadata changes.Testing
git diff --checkmake -f makefile.mingw testsfrom MSYS2 UCRT64 insrc/