Test address generator#1895
Closed
g1itch wants to merge 1 commit intoBitmessage:v0.6from
Closed
Conversation
g1itch
force-pushed
the
addressgenerator
branch
2 times, most recently
from
f184db9 to
80d3c3f
Compare
PeterSurda
approved these changes
Dec 13, 2021
Member
PeterSurda
left a comment
PeterSurda
left a comment
There was a problem hiding this comment.
I like it, an interesting workaround for the problems with the current design.
g1itch
force-pushed
the
addressgenerator
branch
from
80d3c3f to
75e25c7
Compare
Collaborator
Author
It is mostly the network-unbundling. Only the last commit is from this PR. |
g1itch
force-pushed
the
addressgenerator
branch
from
75e25c7 to
7b7019f
Compare
Collaborator
Author
|
BTW, I cannot reproduce the buildbot/travis_bionic_python_2.7 failure locally. I have no clue why it happens. |
Member
Yea that looks weird. I think it happens because you're importing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I failed to start a test case for
singleWorkerand decided to begin with something easier. This test succeeds on py27, but for python3 I should probably mix this with an excerpt of mynetworkbranch.