A standalone test case for the API thread#1900
Closed
g1itch wants to merge 3 commits intoBitmessage:v0.6from
Closed
A standalone test case for the API thread#1900g1itch wants to merge 3 commits intoBitmessage:v0.6from
g1itch wants to merge 3 commits intoBitmessage:v0.6from
Conversation
g1itch
force-pushed
the
api-standalone
branch
from
4efc858 to
22d9387
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I've started the standalone testcase for the API thread. IMHO it's the proper way to test the commands, which are not closely tied to the rest parts of PyBM (SQL, AddressGenerator, etc.). And it also brings the
apimodule closer to the python3 compatibility.So far it looks broken in the same way as #1895, but I think that merging the subset of my
networkbranch may help better here. I'm going to write some tests for the network soon.