Fixing recently discovered API bug #1899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Reproduced in https://buildbot.bitmessage.org/#builders/24/builds/4901 |
PeterSurda
approved these changes
Dec 13, 2021
Member
|
Ideally the section which retrieves label from the database would be its own function or method that can be tested separately but this is also good. |
Collaborator
Author
It's a proper commendation, but I think we may use both tests and it's better to be addressed as separate PR. This additional check is just for reproducing the issue in the current code and prevent a regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Here will be a test and fix for the API bug in 'sendMessage' command reported in #1898.