Skip to content

Fixing recently discovered API bug #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Fixing recently discovered API bug #1899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfe7dd1
Reproduce the bug described in #1898 using test_addressbook()
g1itch Dec 11, 2021
ef2d005
Fix #1898
g1itch Dec 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,7 +1134,7 @@ def HandleSendMessage(
queryreturn = sqlQuery(
"SELECT label FROM addressbook WHERE address=?", toAddress)
try:
toLabel, = queryreturn[0][0]
toLabel = queryreturn[0][0]
except IndexError:
pass

Expand Down
12 changes: 11 additions & 1 deletion src/tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ class TestAPI(TestAPIProto):
_seed = base64.encodestring(sample_seed)

def _add_random_address(self, label):
return self.api.createRandomAddress(base64.encodestring(label))
addr = self.api.createRandomAddress(base64.encodestring(label))
return addr

def test_user_password(self):
"""Trying to connect with wrong username/password"""
Expand Down Expand Up @@ -243,6 +244,15 @@ def test_addressbook(self):
entries['address'], sample_deterministic_addr4)
self.assertEqual(
base64.decodestring(entries['label']), 'tiger_4')
# Try sending to this address (#1898)
addr = self._add_random_address('random_2')
# TODO: it was never deleted
msg = base64.encodestring('test message')
msg_subject = base64.encodestring('test_subject')
result = self.api.sendMessage(
sample_deterministic_addr4, addr, msg_subject, msg)
self.assertNotRegexpMatches(result, r'^API Error')
self.api.deleteAddress(addr)
# Remove known address
self.api.deleteAddressBookEntry(sample_deterministic_addr4)
# Addressbook should be empty again
Expand Down