Show model loading progress across the app - #52
Merged
Conversation
…entage # Conflicts: # Sources/Nativ/Features/Models/HuggingFaceHub.swift
Blaizzy
marked this pull request as ready for review
July 23, 2026 00:08
…entage # Conflicts: # Nativ.xcodeproj/project.pbxproj
Collaborator
|
lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Large local models could take a while to load while the UI showed only an indeterminate state. Users now get consistent percentage feedback anywhere they monitor or select the active model.
Impact
Model loading now reports bounded progress from 0–100%, keeps the progress protocol out of visible logs, and clears state on success, failure, termination, or server stop.
Validation
xcodebuildsucceededmlx-vlm-serverlauncher passed--helppython3 -m py_compilegit diff --checkpassed