Skip to content

Fix app icon in updater UI - #54

Merged
Blaizzy merged 1 commit into
mainfrom
ppc/fix-in-app-icon-rendering
Jul 23, 2026
Merged

Fix app icon in updater UI#54
Blaizzy merged 1 commit into
mainfrom
ppc/fix-in-app-icon-rendering

Conversation

@Blaizzy

@Blaizzy Blaizzy commented Jul 23, 2026

Copy link
Copy Markdown
Owner

What changed

  • Load the bundled AppIcon.icns as the canonical in-app application icon.
  • Register that image under AppKit's application-icon name before Sparkle initializes.
  • Use the same image explicitly in the welcome screen.

Why

The corrected macOS app icon from #53 renders properly in Finder and the Dock, but Sparkle and other in-app surfaces can resolve a stale AppKit application-icon rendition. That stale image still includes the unwanted gray frame.

Impact

Updater dialogs, including update errors, and the welcome screen now show the same corrected black rounded icon used by the application bundle.

Validation

  • xcodebuild -project Nativ.xcodeproj -scheme Nativ -configuration Debug -derivedDataPath build/IconVerify CODE_SIGNING_ALLOWED=NO build
  • Reproduced Sparkle's update-error dialog and visually verified that the gray frame is gone.

@Blaizzy
Blaizzy marked this pull request as ready for review July 23, 2026 08:01
@Blaizzy
Blaizzy merged commit 9871251 into main Jul 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant