Add Images tab for image generation / editing - #67
Merged
Conversation
Collaborator
|
this is super cool @lucasnewman, just a question, seems like it preloads a LM, image and voice model without a RAM check, could this cause a OOM? |
Collaborator
Author
Yes, good call. Let me add a specific warning for that. |
# Conflicts: # Nativ.xcodeproj/project.pbxproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of this, I had to be much more rigorous about model kind detection across language/image/speech models. We now support having models across different types preloaded using the underlying feature in mlx-vlm. Image gen/edit as a tool in Chat for use with LMs that support tool calling will be a follow up feature.