Restore JetBrains integration and complete integration test coverage - #94
Merged
Conversation
The JetBrains integration (PR #90) was merged into its stacked base branch (feat/integration-vscode) rather than main, so it never landed. Re-add it onto main: enum case, display/command/summary/install metadata, guided-setup steps and caveat, guided handling in the service switches, and its logo. Also add the guided editors (VS Code, Cline, Cursor, JetBrains) to the coverage set so testEveryIntegrationHasCoverage matches every case in IntegrationTool.allCases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While merging the approved integration PRs, I found that JetBrains (#90) never landed on
main— its PR base was the stacked branchfeat/integration-vscode, so the merge went there instead ofmain, and it diverged. This restores it and fixes the coverage test.What
main: thejetbrainsenum case, display/command/summary/install metadata,isGuidedSetup/guidedSetupSteps/guidedSetupCaveat, guided handling in theconfigure/configurationURL/launchswitches, and its logo asset.IntegrationServicesTests.coveredTools, sotestEveryIntegrationHasCoverage(which assertsSet(IntegrationTool.allCases) == coveredTools) passes. They were omitted when the guided editors were introduced.Checks
swiftc -parseon the changed Swift files.coveredToolsnow equals all 16IntegrationTool.allCases.