Invalidate client URLSessions on deinit to fix file-descriptor leak - #95
Merged
Conversation
The chat, image, and metrics clients each create an ephemeral URLSession but never invalidate it, so its underlying sockets/file descriptors are retained until process exit. The metrics client is recreated on server start and polled while the app idles, so descriptors accumulate over a long-running session until the process hits its open-file limit — surfacing as a CoreAnimation "Too many open files" crash. Invalidate each session in deinit so its descriptors are released when the client is deallocated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat, image, and metrics clients each create an ephemeral URLSession but never invalidate it, so its underlying sockets/file descriptors are retained until process exit. The metrics client is recreated on server start and polled while the app idles, so descriptors accumulate over a long-running session until the process hits its open-file limit, causing a CoreAnimation "Too many open files" crash seen in #84.
This includes deinit so descriptors are released when the client is deallocated.