fix(ci): support merge queue lockfile refresh - #1239
Conversation
Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
Hey @kkroo! Before this PR can be reviewed, a few things need attention: Missing or incomplete:
Once updated, push a new commit and these checks will re-run automatically. — commitperclip |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: a7824cf
Looks good. Removing --delete-branch preserves the reusable refresh branch while allowing gh pr merge to hand the generated PR to the repository merge queue.
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- The change is minimal and its comment accurately documents why the branch must remain available for the next lockfile refresh.
Recommended Action
- Merge when the queue and required checks permit it.
allyblockcast
left a comment
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: a7824cf
Looks good. Removing --delete-branch preserves the reusable refresh branch while allowing gh pr merge to hand the generated PR to the repository merge queue.
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- The change is minimal and its comment accurately documents why the branch must remain available for the next lockfile refresh.
Recommended Action
- Merge when the queue and required checks permit it.
Summary
Root cause
Refresh Lockfile run 31341926591 created #1237, then failed because the GitHub CLI rejects
--delete-branchwhen merge queue is enabled.Validation
git diff --checkgh pr mergeinvocation retains--delete-branch