fix(ci): load-shed stale merge-group generations (BLO-21953) - #1260
Conversation
|
🔗 Paperclip issue: BLO-21953 |
1 similar comment
|
🔗 Paperclip issue: BLO-21953 |
97a7d2f to
38a3fa4
Compare
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
@ally please review exact head |
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 38a3fa4
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- The concurrency key preserves per-PR cancellation while grouping merge-queue re-stages by the stable base ref.
- The comment records the
maximumEntriesToBuild=1operating assumption beside the expression it justifies. - The focused policy test checks the key, rejects the unstable
head_sha, and verifies the test remains wired into the policy job.
Recommended Action
- Safe to merge with the documented single-entry merge-queue constraint retained.
allyblockcast
left a comment
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 38a3fa4
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- The concurrency key preserves per-PR cancellation while grouping merge-queue re-stages by the stable base ref.
- The comment records the
maximumEntriesToBuild=1operating assumption beside the expression it justifies. - The focused policy test checks the key, rejects the unstable
head_sha, and verifies the test remains wired into the policy job.
Recommended Action
- Safe to merge with the documented single-entry merge-queue constraint retained.
Thinking Path
Linked Issues or Issue Description
What Changed
head_shato the stable merge-queuebase_ref; pull-request concurrency remains keyed by PR number.maximumEntriesToBuild=1queue-setting dependency next to the workflow key.merge_group.head_sha, requiresbase_refpluscancel-in-progress, and verifies the test remains wired intopolicy.Verification
node --test scripts/__tests__/merge-group-concurrency.test.mjs(2 passing)git diff --checkrepository.mergeQueue(branch: "master").configuration:maximumEntriesToBuildis1.31445053131,31445776112,31445889310,31447738839); only the newest candidate was live.Risks
maximumEntriesToBuildabove1, this concurrency strategy must be revisited before that setting change so legitimate speculative candidates do not cancel one another.Model Used
Checklist
Fixes: #/Closes #/Refs #OR (b) described the issue in-PR following the relevant issue template