feat(alertmanager): route paperclip_data_volume to an owner + sync docker adapter-pin test (BLO-10699) - #448
Merged
Merged
Conversation
…er (BLO-10699) The byte-usage watermark alert on the shared `paperclip-data` CephFS PVC (PaperclipDataVolumeNearlyFull/Critical, onprem-k8s#804) carries `class: paperclip_data_volume` but had no entry in DEFAULT_OWNER_MAP, so it fired unassigned. Add a durable default route to support@blockcast.net, mirroring the existing paperclip_claude_k8s route. Operator config still overrides via mergeOwnerMap (worker.ts). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Hey @kkroo! Before this PR can be reviewed, a few things need attention: Missing or incomplete:
Once updated, push a new commit and these checks will re-run automatically. — commitperclip |
… added) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Hey @kkroo! Before this PR can be reviewed, a few things need attention: Missing or incomplete:
Once updated, push a new commit and these checks will re-run automatically. — commitperclip |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
#447 bumped CLAUDE_K8S_REF af5df84→f79ab9a and OPENCODE_K8S_REF 4b195304→cac7d0b in the Dockerfile but did not update docker-opencode-runtime-pin.test.ts, which hard-pins the expected SHAs. That left master red (Release verify_canary) and broke every PR off master. Update the two pinned SHAs to match; all comment-string assertions still hold. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Merged
1 task
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue (inline description — BLO-10699 follow-up)
What happened?
The byte-usage watermark alerts on the shared
paperclip-dataCephFS PVC(
PaperclipDataVolumeNearlyFull/PaperclipDataVolumeCritical, shipped inonprem-k8s#804) carry the label
class: paperclip_data_volume. The alertmanagerplugin's
DEFAULT_OWNER_MAPonly routesclass: paperclip_claude_k8s, so thisnew alert resolves to
source: "no-match"and the auto-created Paperclip issueis unassigned — nobody is paged for a filling shared HOME that walls the
whole agent fleet at workspace materialization (the EDQUOT incident itself).
Expected behavior
The data-volume alert class routes to a durable default owner, like every other
bundled alert class.
Steps to reproduce
Fire an Alertmanager alert with
labels.class = "paperclip_data_volume"and nopaperclip_assignee_emailoverride → today the resulting issue has no assignee.Paperclip version or commit
master@ c772d35 (current tip).Thinking Path
The resolver (
owner-resolver.ts) is pure and order-driven: a direct overridelabel wins first, then the merged
ownerMapis matched by label key, then anannotation override, else
no-match. The data-volume alert carries no overridelabels, so the only place to give it an owner without operator config is the
bundled
DEFAULT_OWNER_MAP— exactly wherepaperclip_claude_k8salready lives,keyed on the same
classlabel. So the minimal, consistent fix is one map entrymirroring the existing class route, rather than touching resolution logic. I kept
it in
DEFAULT_OWNER_MAP(not a hardcoded resolver branch) becausemergeOwnerMapin worker.ts layers operator instance config on top of the defaults, so this stays
an overridable default, not a lock, and is covered by the existing merge tests.
What Changed
constants.ts: addpaperclip_data_volume: "support@blockcast.net"underDEFAULT_OWNER_MAP.class, mirroring the existingpaperclip_claude_k8sentry, with a comment tying it to the onprem-k8s alert.owner-resolver.test.ts: add a test asserting the new class resolves tosupport@blockcast.netviasource: "owner-map"(mirrors the claude_k8s default-route test).server/src/__tests__/docker-opencode-runtime-pin.test.ts: sync the pinned adapter SHAs to chore(docker): bump CLAUDE_K8S_REF + OPENCODE_K8S_REF — Chrome BrowserMetrics + --resume guard (BLO-10699) #447's bump (CLAUDE_K8S_REFaf5df84→f79ab9a,OPENCODE_K8S_REF4b195304→cac7d0b). chore(docker): bump CLAUDE_K8S_REF + OPENCODE_K8S_REF — Chrome BrowserMetrics + --resume guard (BLO-10699) #447 bumped the Dockerfile refs but missed this guard test, leavingmasterred (Release verify_canary) and breaking every PR off master — this PR carries the test-side fix that should have ridden with chore(docker): bump CLAUDE_K8S_REF + OPENCODE_K8S_REF — Chrome BrowserMetrics + --resume guard (BLO-10699) #447. All comment-string assertions in the guard still hold.Verification
pnpm exec vitest runinpaperclip-plugin-alertmanager: 72/72 pass (owner-resolver 24, worker 30, issue-mapping 18).resolveOwnerEmail→ theclasslabel hits the merged map → email branch →owner-map.mergeOwnerMapis key-additive, so operator overrides remain intact (covered by existing worker tests).Risks
ownerMapconfig without a code change. No schema/secret/infra change.Model Used
Claude Opus 4.8 (1M context).
🤖 Generated with Claude Code