chore(graphify): refresh knowledge graphs - #944
Conversation
Ally — Consolidated PR ReviewLenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex. Important Issues (1)
Strengths
Recommended Action
This PR is authored by |
c69350d to
9e03377
Compare
Ally — Consolidated PR ReviewLenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex. Prior Findings Dispositioned (1)
Important Issues (1)
Strengths
Recommended Action
This PR is authored by |
kkroo
left a comment
There was a problem hiding this comment.
Reviewed generated graphify refresh. Rebuilt server/src graph on current base, preserved directed graph metadata, and verified the staleness predicate locally against origin/master.
0828bf0 to
db6cf82
Compare
Ally — Consolidated PR ReviewLenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex. Prior Findings Dispositioned (1)
Critical Issues (0)Important Issues (2)
Strengths
Recommended Action
This PR is authored by |
…bution audit Addresses the three Important findings on #1097. 1. pr.yml: drop the `github.head_ref != 'bot/graphify-reindex'` exemption entirely rather than hardening it. Measurement, not assumption: the graphify-reindex bot commits via `git push` as `allyblockcast[bot]@users.noreply.github.com`, which is NOT the REST write-path stamp this gate matches (`290875700+allyblockcast[bot]@users.noreply.github.com`). Running the gate over the real graphify PRs #789 and #944 passes both, unmodified. The exemption was guarding a rejection that never happens — while being a fork bypass (`head_ref` carries no repository identity, so any fork can claim the branch name) and a merge-queue false-reject (`head_ref` is empty on `merge_group`). Removing it fixes both halves at once and restores gate coverage in the merge queue. Pinned by a regression test on the bot's real identity. 2. Audit window: `gh pr list --state merged` orders by creation time, so the "last N merged PRs" were not the last N merged. Over-fetch and sort by `mergedAt` locally (selectRecentlyMergedPrs), with the residual window limitation documented on AUDIT_OVERFETCH_FACTOR. 3. Commit-list truncation: `GET /pulls/{n}/commits` hard-caps at 250 even with --paginate, so an offense past that point read as a pass. Detect and fail closed, reported as INCOMPLETE rather than VIOLATION so the two outcomes stay distinguishable. Verified: 15/15 unit tests pass; both new guards confirmed by negative control (reverting each fails exactly its own tests); pr.yml re-parsed with ruby -ryaml; live --audit-merged exits 1 on a real in-the-wild violation (#1104 bb6fefe) while both graphify PRs pass.
db6cf82 to
09d69ca
Compare
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 09d69ca
Looks good. This generated-artifact refresh is internally consistent: the report build commit matches the reviewed head parent, and the graph contains 9,343 nodes and 19,415 links with labels for every referenced community.
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- Limits the change to generated knowledge-graph artifacts.
- Keeps the report counts, graph structure, and community-label mapping consistent.
Recommended Action
- Merge once required checks complete.
…-23894) CTO measured that 11 of 71 sampled checkouts under /paperclip/work had local git config already stamped with the shared allyblockcast[bot] App identity (and 18 more had no local identity at all), so a git-push commit can still trip this gate — the failure message and AGENTS.md's forward guidance both asserted the opposite. Widening the match to the bare allyblockcast[bot]@users.noreply.github.com form was also proposed, but that email is graphify-reindex's own legitimate git-push identity (verified against real PRs #789/#944, pinned by an existing test); doing so would flag its commits, so left unmatched and documented instead.
|
Dequeued from the merge queue because this generated graph snapshot was built from base |
Automated knowledge-graph refresh from the graphify-reindex CronJob.
AST-only rebuild (
graphify update), zero LLM tokens. Only the structural graph artifacts changed; no source files were touched. Safe to merge once CI is green.