Fix Waveshare S3 home fingerprint

[oroderico]

Root Cause

On Waveshare ESP32-S3 LCD Touch (portrait), the Home screen header has less
horizontal space than landscape boards. The default title uses the full
device_name string (e.g. Jade <short-id>), which can be clipped on the
portrait header.

The device identifier itself is correct; only the rendering is affected.

Fix

For Waveshare S3 only (CONFIG_BOARD_TYPE_WS_TOUCH_LCD2), adjust the Home
screen activity title:

• When the device name matches the expected Jade prefix, the UI uses only
  the suffix portion (skipping the Jade prefix) as the title.
• This reduces the title width in portrait mode and avoids truncation.

Implementation Notes

• Minimal, localized change: only affects the Home screen title argument passed
  to gui_make_activity_ex().
• No changes to ID generation, session/scan logic, or other boards.

[jgriffiths]

Hi, I think the problem of titles being too wide for screens in given orientations should be considered a generic one, and so fixed generically rather than on a per-screen and/or per-device basis, even if this needs to be opted into with a flag.

[oroderico]

I can fix this, but I did it this way because I didn't have other boards to test the behavior of the fix. Can I adjust the code?

[trevarj]

This was discussed before here, implemented as scrolling when the name doesn't fit, but ultimately discarded before merging the Waveshare stuff into master. Leaving it here for reference.

[oroderico]

I updated this PR to address the title width issue generically instead of using a Waveshare-specific title shortening.

The current version adds an opt-in status bar title scroll flag and enables it on the Home activity, keeping the full device name. I tested it on the Waveshare ESP32-S3 Touch LCD 2 and confirmed the title scrolls correctly instead of being clipped.

One UX question: since the Home screen already shows the large Blockstream Jade logo, the Jade prefix in the status bar may be redundant there. Another possible approach would be to keep the status bar title fixed and show only the 6-character fingerprint, instead of scrolling Jade <fingerprint>.

Do you prefer the generic scrolling approach, or would you rather keep the Home status bar title fixed and shorten the displayed name?

[oroderico]

I also prepared the fixed-title alternative here for comparison:

https://github.com/oroderico/Jade/tree/test-pr274-home-fingerprint-no-jade

This version keeps the full Home status bar title when Jade <fingerprint> fits. If it would be clipped, it falls back to showing only the fingerprint. The full device name remains unchanged elsewhere.

I tested this on the Waveshare S3 Touch LCD2, where it falls back to the fingerprint-only title as intended. I do not have the larger touch-display boards, such as M5 Core2/CoreS3, to verify directly, but the fallback is based on the measured title width, so those boards should keep the full title when it fits.

Personally, I prefer this approach because it avoids scrolling on the Home screen while still preserving the full Jade <fingerprint> title on boards where it fits.

Note: thanks to @CaTeIM for the touchscreen cleanup in #307. This branch currently includes that cleanup only so it can be tested on the Waveshare S3 Touch LCD2 with the current tree. If this approach is preferred, I can rebase after #307 lands and keep the final PR scoped to the Home title change only.

[jgriffiths]

@oroderico I like your solution, it won't make this release as we are limiting changes during the beta period though. If you'd like to PR it though, I'll review and merge once 1.0.41 is released, thanks!

[oroderico]

@jgriffiths Thanks, sounds good!

I’ll open the fixed-title approach as a separate PR now so it is ready for review after 1.0.41 is released. I also rebased it on current master now that #307 has landed, so the final diff is scoped only to the Home title change.