feat(witness): resolve file values against program-declared types#371
Merged
Conversation
LesterEvSe
approved these changes
Jul 14, 2026
LesterEvSe
left a comment
LesterEvSe
left a comment
Collaborator
There was a problem hiding this comment.
ACK 3fe6c4a; tested locally with just check and just check_fuzz
KyrylR
force-pushed
the
feat/typed-witness-boundary
branch
from
July 17, 2026 16:21
80c3f02 to
3fe6c4a
Compare
Contributor
|
39719e4 needs rebase |
KyrylR
marked this pull request as draft
July 18, 2026 10:31
KyrylR
force-pushed
the
feat/typed-witness-boundary
branch
from
July 18, 2026 11:28
39719e4 to
3fe6c4a
Compare
KyrylR
marked this pull request as ready for review
July 18, 2026 11:28
KyrylR
force-pushed
the
feat/typed-witness-boundary
branch
from
July 18, 2026 11:30
3fe6c4a to
0e1da07
Compare
Collaborator
Author
|
In 538d17a fixed a doc comment to avoid rustdoc link to a private element |
KyrylR
force-pushed
the
feat/typed-witness-boundary
branch
2 times, most recently
from
July 18, 2026 12:16
c337076 to
afafbd5
Compare
KyrylR
force-pushed
the
feat/typed-witness-boundary
branch
from
July 18, 2026 12:18
afafbd5 to
004260f
Compare
Collaborator
Author
|
In last commits did rebase and CI fixes |
KyrylR
force-pushed
the
feat/typed-witness-boundary
branch
from
July 18, 2026 12:56
9422aba to
00c75ca
Compare
Collaborator
|
utACK 00c75ca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I started implementing enums like in Rust (nominative) I struggled a lot with the fact types are in the .args and .wit files
Because we have access to the program and actual compiler instead of providing types twice we can just rely on the program itself
apoelstra if there was a security reason pls let me know