feat(extension): add clear-signing manifest review - #17
Open
lukachi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 8 of 9 in the tx-manifest merge train, stacked directly on #16.
Trust boundary
Values retain one of four origins: verified against the network, read from the chain, computed by the wallet, or claimed by the site. Site-authored prose and names are visibly attributed; malformed confirmation data cannot expose an approval action.
The fee shown here is a conservative pre-approval model inherited from the completed cumulative implementation. This slice deliberately does not sign merely to calibrate it; exact-module signing and charged-fee handling remain in the final integration slice.
Deliberate exclusions
This PR does not change the process method, register the renderer, acquire credentials, sign or finalize a transaction, broadcast, activate the RPC method, change the release, or repair the accepted repository-wide dependency-family debt. PR 9 owns those cumulative activation concerns.
The committed smplx submodule pointer remains
8f0215c.Verification
bun run typecheck:packagesbunx tsc -p apps/extension/tsconfig.confirmation.jsonbun --filter=./apps/web run typecheck:toolingbun test packages/tx-manifest— 533 passbun run lint— no errors; existing warnings onlybun run format:check