restore previous logic with match arms - #6
Merged
Merged
Conversation
ikripaka
added a commit
that referenced
this pull request
Aug 24, 2026
* Init Rust project * add ui tests and deps * add more ui tests * Add core implementation of cli and move code from `simplefmt` repo * Refactor exising code * Fix --check command and printing of values * add colours * fix double newlines printing on them * add trailling newline as a default option * edit tests, fix newline error detection on check * improve formatting * add hint for missing newline character * add semicolon span for inserting newline * add custom edit context for collecting idents in match edits * add grouped formatting for long let chains * align code with recent changes in enums and diagnosis errors * fix linting * update clippy command in the CI * Add additional tests and align parsing api * edit tests in - cli.rs - config.rs - fmt.rs * Adapt code to recent changes * add cli check to check argumetns after overriding them * fix ui tests * correct comparing behaviour * add README.md * add ui test for trailling comas in tuples * Preserve literal values for underscored decimals, Fix tests and formatting mistakes * align ui tests with recent changes * add more unit tests for local testing, simplify testing with utils * make more efficient search of trivia tokens * make correct alignment of match arms * remove additional wrapping of oneline match arms * remove trailling coma for tuple types priting * Fix lints, add tests * now comments are added without line ending with a newline * edit rewriting of match expression when we're collecting edits * make more flexible printing of match arms without comments * Refactor doc, remove collection of edits to inject comments dynamically * add errorneous ui test case, update contracts * make handling of comments easier * remove custom edit context and copying of original file when we have comments inside it * Add cargo deny check * Update toml files * Add CHANGELOG.md, CODE_OF_CONDUCT.md, CONTRIBUTING.md * Edit issue templates * Add workflows and cli utils for running simfmt in ci * Fix error naming in simfmt * Edit docs * add Design.md * fix error in CODE_OF_CONDUCT.md * extend README.md * Change simplicityhl deps onto master one * Crates polishing (#5) * Refactor modules visibility * edit READMEs amd Design.md * rearrange imports * Remove unused code * Change prettysimf api * change input parameter from String to impl Into<String> to reduce amount of effort to execute it * Add just file and update CI with feature entry * Update Cargo.tomls and Readmes * Edit Design.md * Fix lints and apply clippy suggestions * Remove automatic rearranges of match branches * update README.md * restore previous logic with match arms (#6) * fix public visibility naming (#7) * Add cmr check for contracts (#8) * Update date in CHANGELOG.md * Update simplicityhl deps (#9) * Update readmes (#10)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems we currently have a limitation where we can't perfectly preserve the original order of the match arms
Right now, the parser provides them in a fixed order (we typically receive the negative option first)
I’ve added a temporary fix for this, though ideally, we'd want to address it in the parser later
For now, the behaviour will be:
#3