BL-2353 Fix image width on xmatter to use full width#567
Merged
hatton merged 1 commit intoBloomBooks:masterfrom Jun 19, 2015
Merged
BL-2353 Fix image width on xmatter to use full width#567hatton merged 1 commit intoBloomBooks:masterfrom
hatton merged 1 commit intoBloomBooks:masterfrom
Conversation
* Fix BL-1022 in basePage.less was overridden by xmatter css which have wider relative marginBox margins * also changed capitalization on @import to match actual DistFiles folder name (in case we build less->css on linux someday)
Contributor
There was a problem hiding this comment.
I don't see why this one is 2*@MarginOuter rather than @MarginOuter + @MarginInner. I think a comment is indicated.
Is there another case for something like @MarginEven when they are balanced?
Contributor
Author
There was a problem hiding this comment.
The comment on line 20 is pre-existing:
//Just center the margin box, (for now, we're ignoring the binding)
Probably because it's not in publishmode yet.
Member
There was a problem hiding this comment.
We are intentionally just centering the cover, as binding has little or no effect on the cover.
hatton
added a commit
that referenced
this pull request
Jun 19, 2015
BL-2353 Fix image width on xmatter to use full width
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which have wider relative marginBox margins
DistFiles folder name (in case we build less->css on linux
someday)