This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Correct 'projections' for get_syn_descriptions #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilbey
reviewed
Jun 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 91.24% 91.24%
=======================================
Files 95 95
Lines 5685 5687 +2
=======================================
+ Hits 5187 5189 +2
Misses 498 498 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
I realized there was some confusion in my previous attempt. I have made some corrections that should now ensure consistency when |
AurelienJaquier
approved these changes
Jul 9, 2024
ilkilic
changed the title
AurelienJaquier
added a commit
that referenced
this pull request
Aug 9, 2024
* add cvode argument to apply_multiple_stimuli (#191) Co-authored-by: Jaquier Aurélien Tristan <aurelien.jaquier@epfl.ch> * Feat: support custom node sets defined in simulation config (#192) * Add holding current to apply_multiple_stimuli (#193) Co-authored-by: Jaquier Aurélien Tristan <aurelien.jaquier@epfl.ch> * Correct 'projections' for get_syn_descriptions (#187) * add contributing guidelines (#190) * replace amp_cv with relative_skew (#195) * remove double CircuitSimulation (#196) Co-authored-by: Jaquier Aurélien Tristan <aurelien.jaquier@epfl.ch> * CI(dependabot): Bump anothrNick/github-tag-action from 1.69.0 to 1.70.0 (#198) Bumps [anothrNick/github-tag-action](https://github.com/anothrnick/github-tag-action) from 1.69.0 to 1.70.0. - [Release notes](https://github.com/anothrnick/github-tag-action/releases) - [Commits](anothrNick/github-tag-action@1.69.0...1.70.0) --- updated-dependencies: - dependency-name: anothrNick/github-tag-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add bb5-tests (#197) * add bb5-tests * remove gitlab-ci.yml * remove duplicate mod files for bb5-tests and merge them into the 'tests' folder * mod files info * add license header * update Makefile * update readme * Fix: Add missing 'units' attribute to timestamp in example test HDF5 file (#200) * add gh action for paper draft * add paper markdown * update draft-pdf.yml * fix yaml error in paper.md * add explanation to draft-pdf.yml * delete .gitlab-ci.yml for joss-paper * reword draft-pdf rule * trigger draft-pdf in any push * add doi for the unix programming env * add doi for agile software development Martin * add doi for parnas1972criteria * add explanation for figure1 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Aurélien Jaquier <72930209+AurelienJaquier@users.noreply.github.com> Co-authored-by: Jaquier Aurélien Tristan <aurelien.jaquier@epfl.ch> Co-authored-by: ilkilic <10600022+ilkilic@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale for this refactoring is to ensure that
get_syn_descriptionsreturns the description only for the instantiated synapse