This repository was archived by the owner on Feb 26, 2025. It is now read-only.
add explanation for figure1 #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jaquier Aurélien Tristan <aurelien.jaquier@epfl.ch>
Co-authored-by: Jaquier Aurélien Tristan <aurelien.jaquier@epfl.ch>
Co-authored-by: Jaquier Aurélien Tristan <aurelien.jaquier@epfl.ch>
….0 (BlueBrain#198) Bumps [anothrNick/github-tag-action](https://github.com/anothrnick/github-tag-action) from 1.69.0 to 1.70.0. - [Release notes](https://github.com/anothrnick/github-tag-action/releases) - [Commits](anothrNick/github-tag-action@1.69.0...1.70.0) --- updated-dependencies: - dependency-name: anothrNick/github-tag-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add bb5-tests * remove gitlab-ci.yml * remove duplicate mod files for bb5-tests and merge them into the 'tests' folder * mod files info * add license header * update Makefile * update readme
Contributor
Author
|
Hi @ilkilic @AurelienJaquier @darshanmandge this PR adds explanation for figure 1 requested as part of the JOSS review. |
AurelienJaquier
approved these changes
Aug 8, 2024
Contributor
Author
|
Can you merge the PR also @AurelienJaquier ? |
Contributor
|
Before that could you pull master to your branch so that this can pass the tests? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## joss-paper #199 +/- ##
===========================================
Coverage 91.24% 91.24%
===========================================
Files 95 95
Lines 5685 5708 +23
===========================================
+ Hits 5187 5208 +21
- Misses 498 500 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.