Conversation
bogdanromanx
requested review from
MFSY,
hygt,
mdupont,
samuel-kerrien,
umbreak and
wwajerowicz
wwajerowicz
left a comment
wwajerowicz
left a comment
There was a problem hiding this comment.
I can't run this locally because of a missing dependecy:
sbt.ResolveException: unresolved dependency: ch.epfl.bluebrain.nexus#sbt-nexus;0.3.8-SNAPSHOT: not found
can we add some instructions on how to fix it?
| **Status**: active development | ||
| **Source code**: https://github.com/BlueBrain/nexus-kg | ||
| **Status**: active development | ||
| **Source code**: https://github.com/BlueBrain/nexus-kg |
There was a problem hiding this comment.
Is there a reason this whitespace was added here?
There was a problem hiding this comment.
It was intended, to get a line break.
|
Good catch, however I wouldn't add build instructions to the project readme... I would very much prefer to fix the issue (by publishing the artifacts to a public repo). |
| com.bigdata.namespace.test-ns.lex.com.bigdata.btree.BTree.branchingFactor=400 | ||
| com.bigdata.rdf.store.AbstractTripleStore.justify=false | ||
| com.bigdata.rdf.store.AbstractTripleStore.geoSpatial=false | ||
| com.bigdata.namespace.test-ns.spo.com.bigdata.btree.BTree.branchingFactor=1024 |
There was a problem hiding this comment.
test-ns ? is that something we want to put out int he default config ?
There was a problem hiding this comment.
For now, I guess these namespace configs need to be (manually) applied (directly through blazegraph instance) prior to start Nexus KG service in order to benefit from indexing and search.
But the right approach would be to read and applied (user provided or default) namespace configs automatically at boot time.
There was a problem hiding this comment.
Very nice catch; I've just used the index definitions that were present in the docs. I'll regenerate the indices.
There was a problem hiding this comment.
Corrected the issue.
| com.bigdata.rdf.store.AbstractTripleStore.textIndex=true | ||
| com.bigdata.rdf.store.AbstractTripleStore.quads=true | ||
| com.bigdata.rdf.sail.truthMaintenance=false | ||
| com.bigdata.namespace.test-ns.lex.com.bigdata.btree.BTree.branchingFactor=400 |
There was a problem hiding this comment.
Corrected the issue.
bogdanromanx
force-pushed
the
initial-paradox
branch
from
e9056c0 to
a5a3b2c
Compare
|
Is this GTM? |
|
looks fine to me |
Co-authored-by: Simon Dumas <simon.dumas@senscience.ai>
4 participants
No description provided.