ENH: Add Fill Functionality to Create Array Action & Utility File Refactoring - #1295
Merged
Merged
Conversation
nyoungbq
force-pushed
the
enh/issue_1274
branch
3 times, most recently
from
May 9, 2025 13:35
6c3943c to
13ac974
Compare
imikejackson
force-pushed
the
enh/issue_1274
branch
from
May 13, 2025 11:51
32436b6 to
51aaa9b
Compare
imikejackson
approved these changes
May 13, 2025
imikejackson
self-requested a review
May 13, 2025 13:39
imikejackson
force-pushed
the
enh/issue_1274
branch
from
May 13, 2025 13:40
51aaa9b to
defa2d0
Compare
nyoungbq
enabled auto-merge (squash)
May 13, 2025 13:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1274
Added Functionality:
CreateArrayfor both preflight and executeChanges:
MaskComparefunctionality fromDataArrayUtilitiestoMaskCompareUtilitiesConvert(string conversion) functionality fromDataArrayUtilitiestoStringInterpretationUtilitiesCreateArrayfunctionality fromDataArrayUtilitiestoArrayCreationUtilities(therein removing the biggest utility file from being included in most Action headers)CreateDataStorefunctionality fromDataArrayUtilitiestoDataStoreUtilities(therein removing the biggest utility file from being included deep in the datastructure factory functions that are included in nearly everything by proxy)ArrayCreationUtilitieswhich includesStringInterpretationUtilitiesandDataStoreUtilities)DataStorefor setting initialization value (this was done to meet the request of issue (ENH: Create arrays in preflight with a default initialization value. #1274)). The request was originally to pass it to the ctor (This would require reworkingAbstractDataStore, and every factory function and mapping for all of OoC functionality, hard to over emphasize how much of a downstream effect this would have)DataStoreis the only one that has an initialization value.DataArrayUtilitiesin various headers.Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
iif warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filesimplnx/docs/Code_Style_Guide.mdfor a more in depth explanation.Filter Checklist
The help file
simplnx/docs/Porting_Filters.mdhas documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup