ENH: Add option to use 26 neighbor kernel for SegmentFeatures class. - #1373
Merged
joeykleingers merged 6 commits intoOct 21, 2025
Conversation
imikejackson
force-pushed
the
issue/issue_1321_26_neighbor_segment
branch
2 times, most recently
from
July 22, 2025 19:50
5077c6f to
11a9ee5
Compare
imikejackson
force-pushed
the
issue/issue_1321_26_neighbor_segment
branch
from
August 7, 2025 16:48
11a9ee5 to
32ea4cd
Compare
imikejackson
force-pushed
the
issue/issue_1321_26_neighbor_segment
branch
from
September 5, 2025 16:30
32ea4cd to
f5a5d7b
Compare
imikejackson
force-pushed
the
issue/issue_1321_26_neighbor_segment
branch
from
September 29, 2025 12:06
f5a5d7b to
54d3a04
Compare
imikejackson
force-pushed
the
issue/issue_1321_26_neighbor_segment
branch
from
October 6, 2025 19:32
54d3a04 to
66270ed
Compare
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
joeykleingers
force-pushed
the
issue/issue_1321_26_neighbor_segment
branch
from
October 16, 2025 18:03
66270ed to
8d589bb
Compare
JDuffeyBQ
requested changes
Oct 20, 2025
Co-authored-by: Jared Duffey <jared.duffey@bluequartz.net>
Co-authored-by: Jared Duffey <jared.duffey@bluequartz.net>
JDuffeyBQ
approved these changes
Oct 21, 2025
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Jul 24, 2026
… refills * The IsPeriodic option (added in BlueQuartzSoftware#1291) has been silently ignored since the BlueQuartzSoftware#1373 neighbor refactor dropped the wrap logic from the shared SegmentFeatures driver. getFaceNeighbors/getAllNeighbors now take isPeriodic and emit the wrap-around neighbor for boundary cells (each axis wraps independently; axes of extent 1 never wrap), and the driver reports when a Feature crosses a periodic boundary, matching the documented behavior. Pinned by periodic-wrap tests for EBSD (face) and Scalar (face and 26-neighbor schemes). * The burst worklist was shrunk to size 1 after every feature, so the first accepted neighbor of each subsequent feature re-grew it by 100k elements and re-wrote 100k -1 sentinels that nothing ever reads. The list now keeps its high-water size across features and is never sentinel-filled; only indices below the live count are read. Fixes BlueQuartzSoftware#1690 Fixes BlueQuartzSoftware#1691 Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
5 tasks
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Jul 27, 2026
… refills * The IsPeriodic option (added in BlueQuartzSoftware#1291) has been silently ignored since the BlueQuartzSoftware#1373 neighbor refactor dropped the wrap logic from the shared SegmentFeatures driver. getFaceNeighbors/getAllNeighbors now take isPeriodic and emit the wrap-around neighbor for boundary cells (each axis wraps independently; axes of extent 1 never wrap), and the driver reports when a Feature crosses a periodic boundary, matching the documented behavior. Pinned by periodic-wrap tests for EBSD (face) and Scalar (face and 26-neighbor schemes). * The burst worklist was shrunk to size 1 after every feature, so the first accepted neighbor of each subsequent feature re-grew it by 100k elements and re-wrote 100k -1 sentinels that nothing ever reads. The list now keeps its high-water size across features and is never sentinel-filled; only indices below the live count are read. Fixes BlueQuartzSoftware#1690 Fixes BlueQuartzSoftware#1691 Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API and Parameters were added to the "Segment Features" filters to use all 26 connected neighbors or the default 6 face neighbors.