BUG: Fixes issue when segmenting features with a +1 feature count - #1466
Merged
imikejackson merged 1 commit intoNov 14, 2025
Merged
Conversation
imikejackson
changed the title
imikejackson
force-pushed
the
topic/segment_features_bug_fix
branch
5 times, most recently
from
November 13, 2025 18:57
95ce4b8 to
e0373a9
Compare
The number of tuples of the Feature Attribute Matrix was always +1 due to how a counter was being incremented. A new unit test was created to more thoroughly test both the Ebsd and CAxis segment features filters
imikejackson
force-pushed
the
topic/segment_features_bug_fix
branch
from
November 13, 2025 19:12
e0373a9 to
508eda2
Compare
joeykleingers
approved these changes
Nov 14, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous algorithm would always be 1 to high in the number of tuples in the feature attribute matrix versus what was actually found.