BUG: Fix INodeGeometry0D::getBoundingBox upper-corner initialization#1649
Merged
imikejackson merged 1 commit intoJul 1, 2026
Merged
Conversation
getBoundingBox() seeded the upper-right corner with std::numeric_limits<float>::min() -- the smallest POSITIVE normal float (~1.18e-38), not the most-negative value. For any node geometry whose maximum coordinate on an axis is <= ~0 (e.g. centered at or below the origin), the max corner never updated during the vertex walk, producing a wrong/oversized bounding box. Geometries lying entirely in positive space happened to work, which masked the bug. Seed the upper corner with std::numeric_limits<float>::lowest() so the max is computed correctly regardless of where the geometry sits. Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net> (cherry picked from commit f474d86)
imikejackson
approved these changes
Jul 1, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getBoundingBox() seeded the upper-right corner with std::numeric_limits::min() -- the smallest POSITIVE normal float (~1.18e-38), not the most-negative value. For any node geometry whose maximum coordinate on an axis is <= ~0 (e.g. centered at or below the origin), the max corner never updated during the vertex walk, producing a wrong/oversized bounding box. Geometries lying entirely in positive space happened to work, which masked the bug.
Seed the upper corner with std::numeric_limits::lowest() so the max is computed correctly regardless of where the geometry sits.
(cherry picked from commit f474d86)
Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
iif warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filesimplnx/docs/Code_Style_Guide.mdfor a more in depth explanation.Filter Checklist
The help file
simplnx/docs/Porting_Filters.mdhas documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup