OPS: Update to Nav 6 by marcosrdz · Pull Request #5404 · BlueWallet/BlueWallet

marcosrdz · 2023-03-26T16:24:01Z

No description provided.

socket-security · 2023-03-26T16:25:53Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Overtorment · 2023-03-26T18:46:29Z

some tests failed

marcosrdz · 2023-03-27T00:13:34Z

@limpbrains @Overtorment i ts-ignored useNavigation in a commit so it passes CI. Either of you know what changes are needed to avoid using ts-ignore?

limpbrains · 2023-03-27T11:04:12Z

@marcosrdz I believe there is not easy fix. You need to type whole Navigation. I tried to type one screen, but failed :)
This is definetly should be a separate task to do.

Overtorment · 2023-04-13T09:42:46Z

e2e still fails?

Overtorment · 2023-04-27T09:31:56Z

@marcosrdz ^^^

socket-security · 2023-08-28T08:37:38Z

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@react-navigation/native-stack	6.9.17	environment	`+9`	3.4 MB	satya164
@react-navigation/native	5.9.8...6.1.9	environment	`+5/-4`	1.41 MB	satya164
@react-navigation/drawer	5.12.9...6.6.6	None	`+11/-11`	6.4 MB	satya164
react-native-reanimated	2.17.0...3.5.4	environment	`+0/-2`	2.78 MB	tjzel
react-native-safe-area-context	3.4.1...4.7.4	environment	`+0/-0`	239 kB	janicduplessis
react-native-screens	3.20.0...3.27.0	None	`+0/-0`	1.3 MB	kkafar
react-native-image-picker	4.8.5...7.0.2	None	`+0/-0`	178 kB	johandutoit

limpbrains · 2023-08-28T08:57:06Z

Can't run detox locally on this branch.
Getting

    The app has crashed, see the details below:

    @Thread detox.primary(146):
    java.lang.RuntimeException: java.util.concurrent.ExecutionException: androidx.test.espresso.IdlingResourceTimeoutException: Wait for [com.wix.detox.reactnative.idlingresources.NetworkIdlingResource] to become idle timed out
    	at androidx.test.espresso.Espresso.onIdle(Espresso.java:15)
    	at com.wix.detox.TestEngineFacade.awaitIdle(TestEngineFacade.kt:12)
    	at com.wix.detox.adapters.server.ReadyActionHandler.handle(DetoxActionHandlers.kt:25)
    	at com.wix.detox.adapters.server.ActionsExecutor.executeAction$lambda-2$lambda-1(DetoxActionsDispatcher.kt:64)
    	at com.wix.detox.adapters.server.ActionsExecutor.$r8$lambda$nk3cF8ntnfFqbJOcVqd04vjb5nY(Unknown Source:0)
    	at com.wix.detox.adapters.server.ActionsExecutor$$ExternalSyntheticLambda0.run(Unknown Source:8)
    	at android.os.Handler.handleCallback(Handler.java:942)
    	at android.os.Handler.dispatchMessage(Handler.java:99)
    	at android.os.Looper.loopOnce(Looper.java:201)
    	at android.os.Looper.loop(Looper.java:288)
    	at com.wix.detox.adapters.server.ActionsExecutor._init_$lambda-0(DetoxActionsDispatcher.kt:50)
    	at com.wix.detox.adapters.server.ActionsExecutor.$r8$lambda$Hi5vyewqQiQqk57AkJy_cHqNGKY(Unknown Source:0)
    	at com.wix.detox.adapters.server.ActionsExecutor$$ExternalSyntheticLambda1.run(Unknown Source:4)
    	at java.lang.Thread.run(Thread.java:1012)
    Caused by: java.util.concurrent.ExecutionException: androidx.test.espresso.IdlingResourceTimeoutException: Wait for [com.wix.detox.reactnative.idlingresources.NetworkIdlingResource] to become idle timed out
    	at java.util.concurrent.FutureTask.report(FutureTask.java:122)
    	at java.util.concurrent.FutureTask.get(FutureTask.java:191)
    	at androidx.test.espresso.Espresso.onIdle(Espresso.java:10

Strange
Maybe RN 72 will help

marcosrdz · 2023-10-07T21:18:14Z

@limpbrains some screens were coded "incorrectly" and need to have their params modified to add "merge: true"

limpbrains · 2023-10-07T22:11:09Z

Do you mean that every screen should be written assuming that route.params could be undefined?
I kinda don't like it

This reverts commit 6d7e4dc.

marcosrdz · 2023-11-10T06:32:20Z

package.json

    "react-native-haptic-feedback": "2.2.0",
    "react-native-idle-timer": "https://github.com/BlueWallet/react-native-idle-timer#8587876d68ab5920e79619726aeca9e672beaf2b",
-    "react-native-image-picker": "4.8.5",
+    "react-native-image-picker": "5.2.0",


Older version wouldn't compile with any sdk past 32

limpbrains · 2023-11-10T09:12:12Z

scripts/react-native-camera-kit.patch

@@ -0,0 +1,11 @@
+--- ../node_modules/react-native-camera-kit/android/src/main/java/com/rncamerakit/CKCamera.kt


I don't think patch is needed with latest version of camera kit

Its needed for v13. V14 is still beta

limpbrains · 2023-11-10T09:12:59Z

screen/wallets/pleaseBackup.tsx

  const handleBackButton = useCallback(() => {
    // @ts-ignore: Ignore
-    navigation.dangerouslyGetParent()?.pop();
+    navigation.getParent()?.pop();


? Might not be needed

Nav 6 deprecated the "dangerously" part

limpbrains · 2023-11-10T09:14:59Z

android/build.gradle

-        kotlin_version = '1.9.20'
-        kotlinVersion = '1.8.0'
-
+        kotlin_version = '1.7.21'


Why are decreasing kotlin version?

My bad. That was during the trial and error process

GladosBlueWallet · 2023-11-11T00:16:33Z

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/wq3kgjgt7st4jqqp4zna4w5fne?device=pixel4

download apk

GladosBlueWallet · 2023-11-11T10:04:16Z

Wake the fuck up samurai, we have PRs to merge

[all PRs for @Overtorment] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/Overtorment

marcosrdz added 2 commits March 26, 2023 12:19

OPS: Update Nav

0948844

Update package.json

b7b5642

marcosrdz requested a review from Overtorment March 26, 2023 16:24

marcosrdz self-assigned this Mar 26, 2023

marcosrdz changed the title ~~Nav6~~ OPS: Update to Nav 6 Mar 26, 2023

marcosrdz removed the request for review from Overtorment March 26, 2023 16:24

marcosrdz added 4 commits March 26, 2023 15:51

Update package-lock.json

2628005

Merge branch 'master' into nav6

932fcbe

TST: Temporary ignore

2436638

Update Navigation.js

407b4ff

marcosrdz added 3 commits March 30, 2023 11:33

Merge branch 'master' into nav6

2f97f34

Merge branch 'master' into nav6

a8c9d39

Update Podfile.lock

017d308

limpbrains added 2 commits August 28, 2023 10:55

fix: navigation.dangerouslyGetParent -> navigation.getParent

626e014

sync with master

a78290e

marcosrdz and others added 5 commits September 21, 2023 21:22

Merge branch 'master' into nav6

bdf3188

fix: undefined params

262fc2e

sync with master

19b7c35

fix: undefined params

1ffd3f2

fix: undefined params

6867100

marcosrdz added 15 commits November 6, 2023 12:34

Update build.gradle

b3836c3

Update build.gradle

6241686

WIP

6d7e4dc

Merge branch 'master' into nav6

d58e939

Revert "WIP"

34e24cd

This reverts commit 6d7e4dc.

WIP

9f31a8a

WIP

6edbd87

WIP

01a5c79

Merge branch 'master' into nav6

0e9dfeb

Update Podfile.lock

b2c6ad5

Update build.gradle

64c57cd

WIP

dca9977

Update package.json

0a6ab5d

Update package.json

c196149

Update package.json

e5d8b72

marcosrdz requested review from Overtorment and limpbrains November 10, 2023 06:03

marcosrdz commented Nov 10, 2023

View reviewed changes

limpbrains requested changes Nov 10, 2023

View reviewed changes

Update build.gradle

1a3655c

marcosrdz requested a review from limpbrains November 10, 2023 10:57

marcosrdz added 2 commits November 10, 2023 09:58

WIP

1de28a7

WIP

b2d936f

limpbrains approved these changes Nov 10, 2023

View reviewed changes

Merge branch 'master' into nav6

673b4e2

Overtorment approved these changes Nov 11, 2023

View reviewed changes

Overtorment merged commit 42966ea into master Nov 11, 2023

Overtorment deleted the nav6 branch November 11, 2023 11:33

		@@ -0,0 +1,11 @@
		--- ../node_modules/react-native-camera-kit/android/src/main/java/com/rncamerakit/CKCamera.kt

Conversation

marcosrdz commented Mar 26, 2023

Uh oh!

socket-security bot commented Mar 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Overtorment commented Mar 26, 2023

Uh oh!

marcosrdz commented Mar 27, 2023

Uh oh!

limpbrains commented Mar 27, 2023

Uh oh!

Overtorment commented Apr 13, 2023

Uh oh!

Overtorment commented Apr 27, 2023

Uh oh!

socket-security bot commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

limpbrains commented Aug 28, 2023

Uh oh!

marcosrdz commented Oct 7, 2023

Uh oh!

limpbrains commented Oct 7, 2023

Uh oh!

marcosrdz Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

limpbrains Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

marcosrdz Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

limpbrains Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

marcosrdz Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

limpbrains Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

marcosrdz Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

GladosBlueWallet commented Nov 11, 2023

Uh oh!

GladosBlueWallet commented Nov 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

socket-security bot commented Mar 26, 2023 •

edited

Loading

socket-security bot commented Aug 28, 2023 •

edited

Loading