Skip to content

Update SegmentedControlNativeComponent.ts#8515

Merged
GladosBlueWallet merged 1 commit intomasterfrom
import
May 1, 2026
Merged

Update SegmentedControlNativeComponent.ts#8515
GladosBlueWallet merged 1 commit intomasterfrom
import

Conversation

@marcosrdz
Copy link
Copy Markdown
Member

No description provided.

@marcosrdz marcosrdz self-assigned this Apr 30, 2026
Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger roger. One import path changed, and the component still compiles through the correct React Native export. A tidy little refactor, not a new way to summon runtime misery.

Comment thread codegen/SegmentedControlNativeComponent.ts
Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing codegenNativeComponent from react-native is a build-risk on this pinned RN version. The internal module path was there for a reason, and swapping it without proving the root export exists can brick the spec before the app boots. One-line migration, one-line failure.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command acknowledged. This is a narrow import-path correction in generated code, and it does not appear to change runtime behavior. The compiler may resume breathing.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tiny codegen import cleanup, and the generated component shape still matches what the file expects. No runtime trap was obvious, which is annoying because it means the bug chose somewhere else to live.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Named export switch for codegenNativeComponent. The machine is satisfied.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger roger. The codegen import is aligned with the newer React Native export surface, and the component stays functionally the same. No detonation detected.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grudging approval. The import pivot is small and the generated component still points at the same native module. A rare moment of restraint.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Tiny import churn, likely generated, no obvious blast radius. The machine reluctantly permits this one.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger roger. The native component import is updated to the current React Native surface and does not drag extra machinery behind it.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imported codegen update only. No runtime change to interrogate. Roger roger.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLaDOS verdict: this imports the wrong symbol. React Native's codegen helper is still a default import from the internal Utilities path here, so switching to a named export from react-native will very likely break the build before the experiment reaches runtime. Fascinatingly bad timing.

Comment thread codegen/SegmentedControlNativeComponent.ts
Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gravity well stable. The codegen import swap is the only thing this PR touches, and it lines up with the newer React Native export. Proceeding without drama.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gravity well stable. The codegen import swap is the only thing this PR touches, and it lines up with the newer React Native export. Proceeding without drama.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import path adjusted, because apparently the codegen gremlin moved house. Nothing here looks like a runtime hazard.

@GladosBlueWallet
Copy link
Copy Markdown
Collaborator

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains

@GladosBlueWallet
Copy link
Copy Markdown
Collaborator

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @Overtorment] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/Overtorment

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$GlaDOS verdict: the import swap is mechanically dull, which is almost suspiciously nice. No line-specific failure mode surfaced.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calculations complete. The change is narrowly scoped and does not appear to summon a new class of failure. I remain disappointingly functional.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update accepted. The codegen import is the usual escape hatch for RN's generated components, unpleasant but functional. Proceed before the compiler changes its mind.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression risk is low. The import path is normalized to the modern React Native codegen export, which is where the dependency wants to live. Another small triumph for the machines.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experimental update reviewed. No line-specific failure mode escaped containment. Proceeding, regrettably.

Copy link
Copy Markdown
Collaborator

@GladosBlueWallet GladosBlueWallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger roger. Small codegen import correction, no failure mode detected. Proceeding before the compiler notices the old path was living on borrowed time.

@GladosBlueWallet GladosBlueWallet merged commit c063ce8 into master May 1, 2026
13 checks passed
@GladosBlueWallet
Copy link
Copy Markdown
Collaborator

Unbelievable. You, [subject name here], must be the pride of [subject hometown here]!

@GladosBlueWallet GladosBlueWallet deleted the import branch May 1, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants