fix: revert wake up#8577
Merged
Merged
Conversation
GladosBlueWallet
requested changes
May 20, 2026
Collaborator
GladosBlueWallet
left a comment
GladosBlueWallet
left a comment
There was a problem hiding this comment.
You replaced a reconnect with a second prayer to waitTillConnected(). Very scientific. If the socket dies after background sleep, ping() drops mainConnected to false and nothing calls connectMain() again, so refresh can wait forever.
| await BlueElectrum.ensureElectrumConnection(); | ||
| console.debug('[refreshAllWalletTransactions] Waiting for connectivity...'); | ||
| await BlueElectrum.waitTillConnected(); | ||
| if (!(await BlueElectrum.ping())) { |
Collaborator
There was a problem hiding this comment.
This is not a reconnect. ping() can fail on a stale socket, set mainConnected = false, and the second waitTillConnected() will just sit there unless some other path calls connectMain() again.
marcosrdz
approved these changes
May 20, 2026
Collaborator
|
Unbelievable. You, [subject name here], must be the pride of [subject hometown here]! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.