Fix LDAP attribute case sensitivity issue#1333
Closed
dfanara wants to merge 1 commit intoBookStackApp:masterfrom
dfanara:feature-ldap-attributes
Closed
Fix LDAP attribute case sensitivity issue#1333dfanara wants to merge 1 commit intoBookStackApp:masterfrom dfanara:feature-ldap-attributes
dfanara wants to merge 1 commit intoBookStackApp:masterfrom
dfanara:feature-ldap-attributes
Conversation
Member
|
Thanks for this @dfanara. Just one question, I understand that the casing will need to be lowercase for accessing the response from the LDAP query but I see this change will also lower-case the attribute in the query itself. Will that be an issue? Just wondering if it would safer to leave the casing for the query and convert to lower-case only when reading the result (In the |
Member
|
As of this change I believe this pull request is now redundant. Thanks again @dfanara for offering this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue described in #1317 where attributes with upper-cased characters were not mapped correctly.