Skip to content

Fix LDAP attribute case sensitivity issue#1333

Closed
dfanara wants to merge 1 commit intoBookStackApp:masterfrom
dfanara:feature-ldap-attributes
Closed

Fix LDAP attribute case sensitivity issue#1333
dfanara wants to merge 1 commit intoBookStackApp:masterfrom
dfanara:feature-ldap-attributes

Conversation

@dfanara
Copy link
Contributor

@dfanara dfanara commented Mar 15, 2019

Fixes an issue described in #1317 where attributes with upper-cased characters were not mapped correctly.

@ssddanbrown
Copy link
Member

Thanks for this @dfanara.

Just one question, I understand that the casing will need to be lowercase for accessing the response from the LDAP query but I see this change will also lower-case the attribute in the query itself. Will that be an issue?

Just wondering if it would safer to leave the casing for the query and convert to lower-case only when reading the result (In the getUserResponseProperty function maybe).

@ssddanbrown
Copy link
Member

As of this change I believe this pull request is now redundant.

Thanks again @dfanara for offering this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants