build: add the canton-token-forge registry service as a dev dependency - #159
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
🟢 Approval recommended
The change is a mechanical, internally consistent dependency addition matching the issue's acceptance criteria and mirroring the existing git-dependency pattern, with no issues found.
Pull request overview
This PR adds the canton-token-forge registry service as a root-level dev dependency so pnpm exec canton-token-forge-registry can serve instrument metadata and a transfer-factory choice context after a single root pnpm install. It follows the established pattern already used for the canton-wallet-service git dependency: allowlist the build script and exclude the tool from knip's unused-dependency check. This is a mechanical dependency addition (closes #150) with no runtime wiring yet.
Changes:
- Pins
@bootnodedev/canton-token-forgeto thev0.2.0tag as a dev dependency and locks it to the resolved git SHA. - Adds the resolved git specifier to
pnpm-workspace.yamlallowBuildsso pnpm runs the package'spreparebuild (which produces the bin). - Adds the package to
knip.jsonignoreDependenciesso knip does not report it as unused.
File summaries
| File | Description |
|---|---|
package.json |
Adds the @bootnodedev/canton-token-forge#v0.2.0 dev dependency. |
pnpm-lock.yaml |
Locks the git dependency to SHA da18cbebd… and records its Express/openapi-validator transitive graph. |
pnpm-workspace.yaml |
Allowlists the resolved git id for build scripts, with a comment explaining why. |
knip.json |
Ignores the new dependency, which has no import site. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 3/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
b4fa471 to
99d1213
Compare
Summary
Closes #150
Nothing in the repository could serve instrument metadata or a transfer-factory
choice context. The registry ships from canton-token-forge as a git dependency
pinned to a tag.
Changes
pnpm exec canton-token-forge-registryruns from the repo root after one root installDeviations
Acceptance criteria
package.jsonpinsgithub:BootNodeDev/canton-token-forge#v0.2.0pnpm-workspace.yamlallowBuildscarries the resolved git specifierpnpm exec canton-token-forge-registryexits 1 on a missing env var, proving the bin was builtpnpm knippassesTest plan
Automated tests
pnpm installpnpm knip, thenpnpm lintManual verification
pnpm exec canton-token-forge-registryinvalid configurationnamingmissing required env var LEDGER_API_URLBreaking changes
None.
Checklist
Screenshots
None.