chore: build the registry on install instead of vendoring the Daml deps - #164
Merged
lmcorbalan merged 6 commits intoSep 2, 2026
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #158
The root
postinstallranscripts/fetch-dep.sh, so anyone depending on this repository paid for a 124 MB clone ofcanton-network/splicein order to start an HTTP service that never reads a DAR.preparereplaces it: a root install now compiles the registry service and vendors nothing.Changes
package.json:postinstallremoved,preparerunstsc -p registry/tsconfig.json, and the registry's four runtime and three dev dependencies move to the root.registry/package.json: declares the@types/nodeit already resolved transitively. Both lockfiles regenerated.scripts/fetch-dep.shcomment now namenpm run setupwhere they creditedpostinstall.Acceptance criteria
npm installalready succeeded withdpmabsent, becausefetch-dep.shnever needed it.Test plan
Automated tests
Registry lint, build, suite typecheck and unit suite: 205 tests in 10 files, all passing.
Manual verification
In a fresh clone with
dpmoffPATH,npm installandnpm ciboth exit 0 in 2s, emit 16 files toregistry/distand create nodeps/; the built service starts and exits 1 on its own configuration error. The same install onmaintakes 10s and vendors 124 MB with no build.npm run setupstill vendors unchanged. Two mutations red it:preparepointed at a missing tsconfig, and the root manifest withoutpinoandexpress-openapi-validator.Breaking changes
A checkout no longer vendors
deps/as a side effect ofnpm install. Runnpm run setupbefore any Daml build.Checklist
Screenshots
None.