feat: publish the registry as the root package's bin - #165
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #159
The root manifest becomes the npm face of the repository: a scoped name, a
binthat starts the registry service, and afilesallowlist that actually ships the built output. A consumer can now pin this repo as a git dependency and run the service.Changes
package.json:@bootnodedev/canton-token-forge0.2.0,type: module,repository,engines,bin,files.distignore rule moves fromregistry/.gitignoreto the root asregistry/**/dist, because a nested ignore file outranks thefilesallowlist during the pack walk.registry/src/index.tsgains a shebang; the node floor rises to 20, which two runtime dependencies require.Acceptance criteria
Test plan
Automated tests
Registry build, both typechecks, lint (40 files), 205/205 unit tests.
Manual verification
From a fresh clone:
npm civendors nothing and emits 16 files toregistry/dist;npm packyields exactly 24 entries; that tarball installed into a consumer outside the repo runs its bin and exits 1 on its own config error. Five mutations all red, including puttingdistback beside the code (0 dist entries shipped) and dropping"type": "module"(the ES module fails to load).Breaking changes
The supported node floor moves from 18 to 20. Two packages in the runtime closure already required it, so
>=18was a promise the package could not keep.Checklist
Screenshots
None.