feat: guard the root and registry manifests against dependency drift - #166
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #160
The root manifest now ships the registry as an npm package, so the same seven packages are named in two files with nothing keeping them in step.
npm run check:depsfails when they come apart.Changes
scripts/check-registry-deps.mjs: a runtime dependency declared on one side only, a shared package at two ranges, a mismatchedengines.nodeortype, and a package the two lockfiles resolve differently.npm cirefuses and that a range edit leaves behind.check:depsentry in the rootpackage.json.Acceptance criteria
engines.nodeandtype). Comparison is symmetric, which the issue asked one way.Test plan
Automated tests
None; the script is its own check and no suite changed.
Manual verification
Twelve mutations redden with the intended message, including a lockfile-only version drift with both manifests agreeing, and a range shadowed by a second declaration of the same package. Green from a fresh clone with nothing installed.
Breaking changes
None.