Feature: Add count up/down, open/closed and re-work ping monitor view - #3572
Merged
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds live scan-status counts and streamlines the Ping Monitor interface.
Changes:
- Adds up/down and open/closed live counters.
- Adds per-group Ping Monitor summaries and status tooltips.
- Simplifies Ping Monitor details and updates localization/changelog content.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
Website/docs/changelog/next-release.md |
Documents the new counters. |
Source/NETworkManager/Views/PortScannerView.xaml |
Displays port totals. |
Source/NETworkManager/Views/PingMonitorView.xaml.cs |
Exposes host status data. |
Source/NETworkManager/Views/PingMonitorView.xaml |
Streamlines monitoring UI. |
Source/NETworkManager/Views/PingMonitorHostView.xaml |
Displays group summaries. |
Source/NETworkManager/Views/IPScannerView.xaml |
Displays host totals. |
Source/NETworkManager/ViewModels/PortScannerViewModel.cs |
Buffers port counters. |
Source/NETworkManager/ViewModels/PingMonitorViewModel.cs |
Provides status tooltip text. |
Source/NETworkManager/ViewModels/PingMonitorHostViewModel.cs |
Tracks group status changes. |
Source/NETworkManager/ViewModels/PingMonitorGroupSummaryConverter.cs |
Calculates group summaries. |
Source/NETworkManager/ViewModels/IPScannerViewModel.cs |
Buffers host counters. |
Source/NETworkManager.Models/Network/PortScanner.cs |
Counts port states. |
Source/NETworkManager.Models/Network/IPScanner.cs |
Counts host states. |
Source/NETworkManager.Localization/Resources/Strings.resx |
Adds summary labels. |
Source/NETworkManager.Localization/Resources/Strings.Designer.cs |
Exposes generated resources. |
Files not reviewed (1)
- Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+121
to
+124
| if (portState == PortState.Open) | ||
| Interlocked.Increment(ref _portsOpen); | ||
| else | ||
| Interlocked.Increment(ref _portsClosed); |
Comment on lines
+24
to
+26
| private int _progressValue; | ||
| private int _portsOpen; | ||
| private int _portsClosed; |
Comment on lines
+23
to
+25
| private int _progressValue; | ||
| private int _hostsUp; | ||
| private int _hostsDown; |
Comment on lines
+420
to
+421
| if (e.PropertyName is nameof(PingMonitorViewModel.IsReachable) or nameof(PingMonitorViewModel.IsRunning)) | ||
| HostsChangeVersion++; |
Comment on lines
+522
to
+526
| HostsUp = 0; | ||
| HostsDown = 0; | ||
| Volatile.Write(ref _latestHostsScanned, 0); | ||
| Volatile.Write(ref _latestHostsUp, 0); | ||
| Volatile.Write(ref _latestHostsDown, 0); |
Comment on lines
+476
to
+480
| PortsOpen = 0; | ||
| PortsClosed = 0; | ||
| Volatile.Write(ref _latestPortsScanned, 0); | ||
| Volatile.Write(ref _latestPortsOpen, 0); | ||
| Volatile.Write(ref _latestPortsClosed, 0); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
To-Do
Contributing
By submitting this pull request, I confirm the following: