fix(discord_bot): guild-only sync command + global command cleanup - #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Slash commands appeared twice in Discord's command picker. Startup syncs the command tree to
SYNC_GUILD_ID(guild-scoped), but a global sync (e.g. the old bare!sync/tree.sync()) had also registered every command globally. Discord shows global + guild-scoped copies side by side.Changes
!syncis now guild-only: bare /~/*/^all sync the current guild only; the globaltree.sync()path is removed so globals cannot be re-created.!sync !spec: fetches all globally registered commands from the API and deletes them (one-time cleanup for the stale duplicates).sync_command_tree) is unchanged.Usage
After deploy, run
!sync !once as bot owner to delete the stale global commands.Verification
uv run ruff check/ruff format --check .cleanuv run pytest: 140 passeduv run mypy: same 7 pre-existing errors as develop, none introduced