Skip to content

feat: Allow pandas 2.3.2 #699 - #700

Open
bp-junichi-mori wants to merge 1 commit into
masterfrom
feature/allow-pandas-232
Open

feat: Allow pandas 2.3.2 #699#700
bp-junichi-mori wants to merge 1 commit into
masterfrom
feature/allow-pandas-232

Conversation

@bp-junichi-mori

Copy link
Copy Markdown
Collaborator

Brief

Workaround for the pandas 2.3.3 issue.
Updating supported pandas versions to 2.3.2–2.3.3.

Fixes #699

Test

Confirmed

  • Installing cliboa when pandas is not already installed results in the installation of version 2.3.3.
  • No errors occur when installing cliboa, even if pandas 2.3.2 is already installed.
  • CSV operations using pandas 2.3.2 (such as CsvMerge and CsvInsert) function correctly without issues.

@bp-masaaki-kodama bp-masaaki-kodama left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I understand that since 2.3.3 is still allowed after this change, the intent is not to pin to 2.3.2, but to let users drop to 2.3.2 only when they need to work around the issue.

One nit: since the previous constraint was >=2.3.3, <3.0.0, I think >=2.3.2, <3.0.0 could also work here, to keep the upper bound as it was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow pandas 2.3.2 to avoid segmentation fault in pandas 2.3.3

2 participants