Rename launcher jar to breaktest.jar (phase one: dual-name transition)#75
Merged
Conversation
Phase one of the launcher rename: - The distribution ships the launcher as bin/breaktest.jar and, for one transition period, an identical copy named bin/ApacheJMeter.jar so self-updaters deployed before this release still accept and install new archives. The copy will be dropped in a later release. - All launch and utility scripts (breaktest, breaktest.bat, agent launchers, heapdump/threaddump/pause/resume/shutdown/stoptest) and the HTML report generator now use breaktest.jar. - The self-updater accepts a launcher under either name when validating archives and installations (UpdateService.hasLauncherJar), backs up both launcher names during installation, and removes a stale legacy jar once a future distribution ships only breaktest.jar - covered by a rename-transition installer test. - Batch test tooling and dist classpaths updated; .gitignore covers both jar names. The Maven artifact name (ApacheJMeter) is unchanged; this renames only the file shipped in the distribution's bin directory. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Branding PR 4, stacked on #74 — the launcher jar rename, choreographed so the self-update path never breaks.
The constraint: every deployed BreakTest validates downloaded update archives by checking
bin/ApacheJMeter.jar. A hard rename would make all existing installs reject the next release.Phase one (this PR):
bin/breaktest.jaras the launcher plus an identical copy namedbin/ApacheJMeter.jar, so already-deployed updaters still accept and install the archive.breaktest.jar:breaktest,breaktest.bat, both agent launchers, and the 12 utility scripts (heapdump/threaddump/pause/resume/shutdown/stoptest, sh+cmd), plusHtmlReportGeneratorand the batch-test tooling.UpdateService.hasLauncherJar) when validating staged archives and the installation dir, backs up both names during install, and cleanly removes a stale legacy jar once a future dist ships onlybreaktest.jar.ApacheJMeter) is intentionally unchanged — this renames only the file in the dist'sbin/.Phase two (a later release, after updaters have rolled forward): drop the
ApacheJMeter.jarcopy from the dist — the updater side is already ready, covered by the rename-transition test.Verification
createDistproduces both jars;bin/breaktest --versionlaunches viabreaktest.jarend-to-end.:src:dist:build, and a dist-check batch test (which runs the CLI through the renamed jar) all green.🤖 Generated with Claude Code