fix: ensure that get_bus_demand works in Create state#422
fix: ensure that get_bus_demand works in Create state#422danielolsen merged 3 commits intodevelopfrom
Conversation
|
|
||
| :return: (*pandas.DataFrame*) -- data frame of demand (hour, bus). | ||
| """ | ||
| self._update_scenario_info() |
There was a problem hiding this comment.
It makes sense. I am confused to why it was working before without the update.
There was a problem hiding this comment.
get_demand uses get_profile which uses self.builder.demand, but get_bus_demand passes self.scenario_info without updating self.scenario_info with what we're setting in the builder.
There was a problem hiding this comment.
When the bug has been introduced because get_bus_demand was working originally.
There was a problem hiding this comment.
Did we test it in Create state after #388?
There was a problem hiding this comment.
Probably not but I thought this was a feature you were using before creating each scenario. That's why I am surprised you just found the bug now.
There was a problem hiding this comment.
Nope, this method was not part of my usual scenario setup process. REISE.jl does the same thing within the Julia code though. This feature was mostly being used for scenarios in Analyze state.
| """ | ||
| demand = InputData().get_data(scenario_info, "demand") | ||
| bus = grid.bus | ||
| demand = InputData().get_data(scenario_info, "demand")[bus.zone_id.unique()] |
…s_demand fix: ensure that get_bus_demand works in Create state
3 participants
Purpose
Fixes a couple of bugs when trying to get bus_demand from a Scenario in Create state. Closes #421.
What the code is doing
scenario_infogets updated before we callget_bus_demand.Testing
The automated tests don't cover this, because getting the demand profiles requires ssh, but you can check that tests pass locally using
python -m pytest.Time estimate
5 minutes.