Update variable names for cost curve visualization#428
Merged
Conversation
jenhagg
reviewed
Mar 26, 2021
jenhagg
approved these changes
Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This change updates the cost curve visualization variable names to be more descriptive.
What the code is doing
No functionality is changed. The refactored code still offers the ability to visualize and explore generator supply curves.
Testing
I updated the tests in
powresimdata/design/generation/tests/test_cost_curves.pyand they pass. I also double checked the outputs with an old demo notebook and the outputs remained the same.Where to look
The refactor is contained within
powersimdata/design/generation/cost_curves.pyandpowersimdata/design/generation/tests/test_cost_curves.py. I also updatedREADME.mdto reflect the changes.Time estimate
This should be pretty quick.