Skip to content

Rewrite README#432

Merged
rouille merged 6 commits intodevelopfrom
ben/readme
Apr 2, 2021
Merged

Rewrite README#432
rouille merged 6 commits intodevelopfrom
ben/readme

Conversation

@rouille
Copy link
Copy Markdown
Collaborator

@rouille rouille commented Mar 31, 2021

Pull Request doc

Purpose

Move sections of README in ReST files located in a new docs folder and rewrite README.

What the code is doing

There is no code

Testing

I have checked that the content of the powersimdata/docs folder is properly display in our docs. To reproduce, checkout this branch and the ben/powersimdata branch in the docs repo and run tox there to make sure that the PowerSimData tutorial displays correctly

Where to look

The content of the ReST files is almost identical to the sections in the current README. The only changes I made are:

The new README is the file that requires attention

Time estimate

Hard to say

@rouille rouille added the documentation Documentation related to package label Mar 31, 2021
@rouille rouille self-assigned this Mar 31, 2021
Comment thread docs/scenario.rst Outdated
Comment thread README.md Outdated
@rouille
Copy link
Copy Markdown
Collaborator Author

rouille commented Mar 31, 2021

Do not hesitate to propose improvements for the README, e.g., more or different bullet points in the Main Features section of the README, etc.

@kasparm
Copy link
Copy Markdown
Contributor

kasparm commented Mar 31, 2021

Looks good @rouille. I like the the tutorial. I created the docs and it displays correctly.
Out of scope: Diagram for software packages and how they interact.

@kasparm kasparm self-requested a review March 31, 2021 16:56
@rouille
Copy link
Copy Markdown
Collaborator Author

rouille commented Mar 31, 2021

Looks good @rouille. I like the the tutorial. I created the docs and it displays correctly.
Out of scope: Diagram for software packages and how they interact.

We might want to use mermaid for that

@BainanXia
Copy link
Copy Markdown
Collaborator

Looks good @rouille. I like the the tutorial. I created the docs and it displays correctly.
Out of scope: Diagram for software packages and how they interact.

We might want to use mermaid for that

Diagrams can be generated automatically? This is fancy!

@danielolsen
Copy link
Copy Markdown
Contributor

Is ReST better than markdown? Should we write new READMEs in ReST?

@rouille
Copy link
Copy Markdown
Collaborator Author

rouille commented Mar 31, 2021

Is ReST better than markdown? Should we write new READMEs in ReST?

ReST is the default plaintext markup language used by Sphinx. So far we have used a plugin to display Markdown file in order to link our package's README. Since, we want i) to have concise README and ii) take full advantage of the more elaborate ReST language, I have translated all the Markdown files to ReST

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread docs/grid.rst Outdated
Comment thread docs/scenario.rst
Comment thread docs/scenario_design.rst Outdated
@rouille rouille force-pushed the ben/readme branch 3 times, most recently from e9418c1 to 0e4d804 Compare April 1, 2021 15:16
@rouille rouille merged commit a1807e1 into develop Apr 2, 2021
@rouille rouille deleted the ben/readme branch April 2, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation related to package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants