Merged
Conversation
danielolsen
reviewed
Mar 31, 2021
kasparm
reviewed
Mar 31, 2021
Collaborator
Author
|
Do not hesitate to propose improvements for the README, e.g., more or different bullet points in the Main Features section of the README, etc. |
Contributor
|
Looks good @rouille. I like the the tutorial. I created the docs and it displays correctly. |
kasparm
approved these changes
Mar 31, 2021
Collaborator
Author
Collaborator
Contributor
|
Is ReST better than markdown? Should we write new READMEs in ReST? |
Collaborator
Author
ReST is the default plaintext markup language used by Sphinx. So far we have used a plugin to display Markdown file in order to link our package's README. Since, we want i) to have concise README and ii) take full advantage of the more elaborate ReST language, I have translated all the Markdown files to ReST |
jenhagg
reviewed
Mar 31, 2021
jenhagg
reviewed
Mar 31, 2021
jenhagg
reviewed
Mar 31, 2021
jenhagg
reviewed
Mar 31, 2021
jenhagg
reviewed
Mar 31, 2021
jenhagg
approved these changes
Mar 31, 2021
ahurli
reviewed
Mar 31, 2021
e9418c1 to
0e4d804
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Move sections of README in ReST files located in a new docs folder and rewrite README.
What the code is doing
There is no code
Testing
I have checked that the content of the powersimdata/docs folder is properly display in our docs. To reproduce, checkout this branch and the
ben/powersimdatabranch in the docs repo and runtoxthere to make sure that the PowerSimData tutorial displays correctlyWhere to look
The content of the ReST files is almost identical to the sections in the current README. The only changes I made are:
The new README is the file that requires attention
Time estimate
Hard to say