Correct bug for Scenario init with bad descriptor#440
Merged
danielolsen merged 2 commits intodevelopfrom Apr 5, 2021
Merged
Conversation
jenhagg
approved these changes
Apr 5, 2021
danielolsen
force-pushed
the
daniel/missing_scenario
branch
from
fa08c7b to
36b0f69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add a test to check a bug for when we try to get a Scenario that isn't in the ScenarioList, and then fix the bug. This bug was introduced in #420.
What the code is doing
We raise a
ValueErrorbefore aRecursionErrorwould be created (the previous bug).Testing
Unit test finds the error before (or crashed python), and confirms that the fix works.
Time estimate
5 minutes.