feat: os agnostic rm functionality

[jenhagg]

Purpose

Another small chunk to support windows natively. This one splits the remove method so that the one in LocalDataAccess is os independent.

What the code is doing

• Add confirmation prompt before running rm command on server, and before deleting local glob matches
• Move the error check on stderr inside the SSHDataAccess implementation, since there is no analog for local version (return types have to match)
• Remove force parameter and hard code the resulting -f option since we always pass it to the server, and it's not needed locally
• Change value passed to recursive in move.py so it matches what we do in delete.py
• Rename test file to match module under test

Testing

The main thing to test is the new glob used in the local implementation. I did this manually by creating some nested folders and checking the files matched. Also tested with the confirmation prompt using the server based container setup.

Time estimate

15 min

[BainanXia]

According to the documentation, it seems glob is used for Unix shell only?

[jenhagg]

I believe "unix style" is just a reference to the origin. There are separate sections in the docs for windows and unix specific features. Will do a test to confirm though.

[jenhagg]

Looks like there could be some inconsistencies (see this post) but it should work for our current use case.

[BainanXia]

Thanks for looking into that. I think it should be fine as long as it works for our current use case. As said, we can always revisit it in the future if our usage goes beyond the available scope.

[danielolsen]

If this fails, it seems like we can use regex workarounds. I don't think we use any [ or ] characters within our data directories, so hopefully any of those characters in parent directories won't be a problem.

[BainanXia]

Not sure how to test it throughout. But some native tests locally on my mac work as expected.

[rouille]

Looks good