Skip to content

Fallback meta default help#7

Merged
BrianPugh merged 4 commits into
mainfrom
fallback-meta-default-help
Dec 2, 2023
Merged

Fallback meta default help#7
BrianPugh merged 4 commits into
mainfrom
fallback-meta-default-help

Conversation

@BrianPugh

@BrianPugh BrianPugh commented Dec 2, 2023

Copy link
Copy Markdown
Owner
  • If an App doesn't have explicit help text, it should fallback to app.default_command.__doc__, then app.meta.default_command, app.meta.meta.default_command, and so on.
  • Also fixes displaying meta command help screen.
  • Doc pages for "help" and "version".

@codecov-commenter

codecov-commenter commented Dec 2, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (93516ca) 92.39% compared to head (2b20ae0) 92.27%.

Files Patch % Lines
cyclopts/core.py 95.83% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   92.39%   92.27%   -0.12%     
==========================================
  Files          10       10              
  Lines        1052     1062      +10     
  Branches      248      252       +4     
==========================================
+ Hits          972      980       +8     
- Misses         45       46       +1     
- Partials       35       36       +1     
Flag Coverage Δ
unittests 92.27% <95.83%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BrianPugh BrianPugh merged commit ef44925 into main Dec 2, 2023
@BrianPugh BrianPugh deleted the fallback-meta-default-help branch December 2, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants